linux-kernel - Re: [PATCH] compat: remove compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2016 12:15:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compat: remove compat_printk

On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
> > @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
> >               .extra1         = &neg_one,
> >       },
> >  #endif
> > -#ifdef CONFIG_COMPAT
> > -     {
> > -             .procname       = "compat-log",
> > -             .data           = &compat_log,
> > -             .maxlen         = sizeof (int),
> > -             .mode           = 0644,
> > -             .proc_handler   = proc_dointvec,
> > -     },
> > -#endif
> 
> How do we know we can simply remove /proc/sys/kernel/compat-log without
> breaking any userspace?
> 

Good point. I guess we can leave this in place just in case (with a comment)
and just remove the compat_printk function. We could probably have a Kconfig
symbol for obsolete sysctl files, but if this is the only one controlled
by it, it's probably not worth the effort.

	Arnd