linux-kernel - Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 16:28:08 -0700
From:	Andrey Smirnov <andrew.smirnov@...il.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant

On Tue, Jun 21, 2016 at 2:26 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> Please always include a commit message.

OK, will fix in v3

>
> On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>> ---
>>  drivers/rtc/rtc-ds1307.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
>> index 821d9c0..7e65e2e 100644
>> --- a/drivers/rtc/rtc-ds1307.c
>> +++ b/drivers/rtc/rtc-ds1307.c
>> @@ -35,6 +35,7 @@ enum ds_type {
>>       ds_1338,
>>       ds_1339,
>>       ds_1340,
>> +     ds_1341,
>>       ds_1388,
>>       ds_3231,
>>       m41t00,
>> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
>>       { "ds1337", ds_1337 },
>>       { "ds1338", ds_1338 },
>>       { "ds1339", ds_1339 },
>> +     { "ds1341", ds_1341 },
>>       { "ds1388", ds_1388 },
>>       { "ds1340", ds_1340 },
>>       { "ds3231", ds_3231 },
>> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
>>               break;
>>       case ds_1340:
>> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
>>
>>       static const int        bbsqi_bitpos[] = {
>>               [ds_1337] = 0,
>> +             [ds_1341] = 0,
>>               [ds_1339] = DS1339_BIT_BBSQI,
>>               [ds_3231] = DS3231_BIT_BBSQW,
>>       };
>> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               /* get registers that the "rtc" read below won't read... */
>>               tmp = ds1307->read_block_data(ds1307->client,
>>                               DS1337_REG_CONTROL, 2, buf);
>> --
>> 2.5.5
>>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com