linux-kernel - Re: [PATCH v3 0/15] Changes to support 150 MHz eMMC on rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 22 Jun 2016 17:23:44 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Douglas Anderson <dianders@...omium.org>
Cc:	Heiko Stuebner <heiko@...ech.de>, Kishon <kishon@...com>,
	Rob Herring <robh+dt@...nel.org>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Ziyuan Xu <xzy.xu@...k-chips.com>,
	Brian Norris <briannorris@...omium.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	groeck@...omium.org, Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Will Deacon <will.deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Stefan Wahren <stefan.wahren@...e.com>,
	zhengxing@...k-chips.com, Michal Simek <michal.simek@...inx.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, jay.xu@...k-chips.com,
	Caesar Wang <wxt@...k-chips.com>,
	Paweł Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Andrei Pistirica <andrei.pistirica@...rochip.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Kumar Gala <galak@...eaurora.org>,
	Yangbo Lu <yangbo.lu@...escale.com>
Subject: Re: [PATCH v3 0/15] Changes to support 150 MHz eMMC on rk3399

On 20 June 2016 at 19:56, Douglas Anderson <dianders@...omium.org> wrote:
> The theme of this series of patches is to try to allow running the eMMC
> at 150 MHz on the rk3399 SoC, though the changes should still be correct
> and have merit on their own.  The motivation for running at 150 MHz is
> that doing so improves signal integrity and (with some eMMC devices)
> doesn't affect throughput.
>
> These patches have been structured to keep things as separate as
> possible, but nevertheless there are still some dependencies between
> patches.  It probably makes the most sense for all of the non-device
> tree patches to go through a single tree.  PHY patches now have Acks
> from Kishon so that means things should be clear for all non-DTS patches
> to go through the MMC tree if Ulf agrees.  Device tree patches should be
> able to be landed separately and the worst what would happen is a
> warning in the kernel log if you have the code without the device tree.
>
> The code patches are based on Ulf's mmc-next.  In v3 of the series I've
> pulled in the latest version of a previous PHY series posted by Brian
> Norris.
>
> The device tree patches are based on Heiko's v4.8-armsoc/dts64.
>
> Changes in v3:
> - Add Brian's PHY patches into my series
> - Add collected tags
> - Add dependency on COMMON_CLK (actually in v2.1) (Guenter Roeck)
> - Use phy_init / phy_exit (Heiko)
> - Add Kishon's Ack
>
> Changes in v2:
> - Drop 170 MHz comment (only applicable to a subtly different Arasan PHY)
> - Indicate that 5.1 ms is calculated (Shawn).
> - Clean up description of rk3399 PHY (Shawn)
> - Add Rob Herring's Ack.
> - Reorder includes (Shawn)
> - Adjust commit message wording (Rob)
> - List out clocks and clock names (Rob)
> - Move code cleanup before set phyctrl_frqsel based on card clock (Shawn)
> - Warn if we're more than 15 MHz from ideal rate (Shawn)
> - Fix typo USB => SDHCI (Shawn)
>
> Brian Norris (2):
>   phy: rockchip-emmc: configure default output tap delay
>   phy: rockchip-emmc: reindent the register definitions
>
> Douglas Anderson (11):
>   phy: rockchip-emmc: Increase lock time allowance
>   mmc: sdhci-of-arasan: Always power the PHY off/on when clock changes
>   Documentation: mmc: sdhci-of-arasan: Add soc-ctl-syscon for corecfg
>     regs
>   mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399
>   arm64: dts: rockchip: Add soc-ctl-syscon to sdhci for rk3399
>   Documentation: mmc: sdhci-of-arasan: Add ability to export card clock
>   mmc: sdhci-of-arasan: Add ability to export card clock
>   Documentation: phy: Let the rockchip eMMC PHY get an exported card
>     clock
>   phy: rockchip-emmc: Minor code cleanup in
>     rockchip_emmc_phy_power_on/off()
>   phy: rockchip-emmc: Set phyctrl_frqsel based on card clock
>   arm64: dts: rockchip: Provide emmcclk to PHY for rk3399
>
> Shawn Lin (2):
>   phy: rockchip-emmc: give DLL some extra time to be ready
>   phy: rockchip-emmc: configure frequency range and drive impedance
>
>  .../devicetree/bindings/mmc/arasan,sdhci.txt       |  35 ++-
>  .../devicetree/bindings/phy/rockchip-emmc-phy.txt  |   9 +
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi           |   5 +
>  drivers/mmc/host/Kconfig                           |   1 +
>  drivers/mmc/host/sdhci-of-arasan.c                 | 333 +++++++++++++++++++--
>  drivers/phy/phy-rockchip-emmc.c                    | 216 ++++++++++---
>  6 files changed, 525 insertions(+), 74 deletions(-)
>
> --
> 2.8.0.rc3.226.g39d4020
>

Thanks, applied for next! (Skipped the DTS changes in patch9 and patch
15, as those will be picked up by Heiko).

Kind regards
Uffe