linux-kernel - Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2016 21:52:47 +0200
From:	Heiner Kallweit <hkallweit1@...il.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

Am 22.06.2016 um 15:25 schrieb Jiri Kosina:
> On Tue, 21 Jun 2016, Heiner Kallweit wrote:
> 
>> Now that support for ThingM blink(1) was merged into the hid-led driver
>> the dedicated driver for this device can be removed.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> ---
>>  drivers/hid/Kconfig      |  10 --
>>  drivers/hid/Makefile     |   1 -
>>  drivers/hid/hid-thingm.c | 259 -----------------------------------------------
>>  3 files changed, 270 deletions(-)
>>  delete mode 100644 drivers/hid/hid-thingm.c
>>
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index ab22090..6b08a3b 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -828,16 +828,6 @@ config HID_TOPSEED
>>  	Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic
>>  	CLLRCMCE remote control.
>>  
>> -config HID_THINGM
> 
> Overall the patchset looks good to me. I'd suggest we keep 
> CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so 
> that we don't cause kernel config regressions for users who had 
> CONFIG_HID_THINGM already turned on.
> 
OK
I'll add this and provide a v2 of the patch removing the old thingm driver.

> Also adding Vivien Didelot to CC, as the author of the original driver. 
> Vivien, the full set can be found in linux-input archives ( 
> http://marc.info/?l=linux-input&r=1&b=201606&w=2 )
> 
Sorry, forgot that.