linux-kernel - Re: [PATCH v3 0/2] nvmem: remove regmap dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 Jun 2016 07:43:48 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	linux-mediatek@...ts.infradead.org,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-kernel@...r.kernel.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/2] nvmem: remove regmap dependency

On Thu, Jun 23, 2016 at 08:07:13PM +0200, Stefan Wahren wrote:
> Hi Greg,
> 
> > Greg Kroah-Hartman <gregkh@...uxfoundation.org> hat am 1. Juni 2016 um 19:55
> > geschrieben:
> > 
> > 
> > On Wed, Jun 01, 2016 at 10:27:49AM +0200, Stefan Wahren wrote:
> > > Hi Greg,
> > > 
> > > Am 02.05.2016 um 20:36 schrieb Srinivas Kandagatla:
> > > > Hi Greg, 
> > > >
> > > > This is v3 patchset for the leftover 2 patches for nvmem regmap
> > > > removal series [1]. These patches are based on char-misc tree.
> > > >
> > > > nvmem uses regmap_raw_read/write apis to read/write data from providers,
> > > > With recent patch 922a9f936e40 ("regmap: mmio: Convert to regmap_bus
> > > > and fix accessor usage") nvmem providers based on regmap-mmio stopped
> > > > working, as nvmem core was using raw accessors.
> > > > This issue can be fixed temporarly by moving to other regmap apis,
> > > > but we might hit same issue in future, and regmap looks like an
> > > > overdo for nvmem. Moving to interfaces based on read/write callbacks
> > > > from providers would be more robust.
> > > >
> > > > This patchset converts the nvmem core and nvmem provider drivers to
> > > > use the new callbacks. Tested this patchset on qfprom and at24 drivers.
> > > > Other driver are only compile tested, any testing on them would be great.
> > > >
> > > > Most of the patches have been applied to char-misc tree, these are the
> > > > two patches which had some outstanding comments on mxs nvmemprovider,
> > > > which are now fixed.
> > > >
> > > > Changes since v2:
> > > >  - Fixed the mxs size and dt data pointer spotted by Stefan and Fabio
> > > >
> > > > Changes since v1:
> > > >  - rebased mtk-efuse on top of char-misc
> > > >  - addressed concerns raised by Stefan Wahren.
> > > >
> > > > [1]
> > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1130026.html
> > > >
> > > > Thanks,
> > > > srini
> > > >
> > > > Srinivas Kandagatla (2):
> > > >   nvmem: mtk-efuse: remove nvmem regmap dependency
> > > >   nvmem: mxs-ocotp: remove nvmem regmap dependency
> > > >
> > > >  drivers/nvmem/Kconfig     |  1 -
> > > >  drivers/nvmem/mtk-efuse.c | 47 ++++++++++++++++++---------
> > > >  drivers/nvmem/mxs-ocotp.c | 83
> > > > +++++++++++++----------------------------------
> > > >  3 files changed, 54 insertions(+), 77 deletions(-)
> > > >
> > > 
> > > any objections about this series or is it still in queue?
> > 
> > still in my queue...
> > 
> 
> gently ping ...

Sorry for the delay, now queued up.

greg k-h