linux-kernel - Re: [PATCH] selftests/lib: set printf.sh executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 18:08:40 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	SeongJae Park <sj38.park@...il.com>,
	Kees Cook <keescook@...omium.org>
Cc:	adriy.shevchenko@...ux.intel.com, linux-kselftest@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/lib: set printf.sh executable

Hi SeongJae Park,

Thanks for the ping.

On 06/24/2016 05:56 PM, SeongJae Park wrote:
> Shuah,
> 
> 
> May I ask your opinion about this patch?
> 
> 
> Thanks,
> SeongJae Park
> 
> On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook <keescook@...omium.org> wrote:
>> On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@...il.com> wrote:
>>> Test for test_printf module fails always because the test program,
>>> printf.sh, has no execution permission.  This commit adds execution
>>> permission to it.
>>>
>>> Signed-off-by: SeongJae Park <sj38.park@...il.com>
>>
>> Acked-by: Kees Cook <keescook@...omium.org>
>>
>> (Is this mode change sufficient, or does the selftest infrastructure
>> need to explicitly set it executable when running?)

This is good and makes it consistent with bitmap.sh the other
shell script in this test suite. I will get this into 4.8-rc1

thanks,
-- Shuah

>>
>> -Kees
>>
>>
>>> ---
>>>  tools/testing/selftests/lib/printf.sh | 0
>>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>>  mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>>>
>>> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
>>> old mode 100644
>>> new mode 100755
>>> --
>>> 1.9.1
>>>
>>
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security