linux-kernel - Re: [PATCH 1/7] Documentation: of: add type property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 00:09:13 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Rob Herring <robh+dt@...nel.org>
CC:	Mark Brown <broonie@...aro.org>, Mark Brown <broonie@...nel.org>,
	Laurent <laurent.pinchart@...asonboard.com>,
	Guennadi <g.liakhovetski@....de>,
	"Grant Likely" <grant.likely@...aro.org>,
	Frank Rowand <frowand.list@...il.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Linux-DT <devicetree@...r.kernel.org>,
	Linux-ALSA <alsa-devel@...a-project.org>
Subject: Re: [PATCH 1/7] Documentation: of: add type property


Hi Rob

Thank you for your review

> > +Each ports / port / endpoint can have its type if needed.
> 
> I think type should only apply to a port. ports is only a grouping for
> multiple ports. endpoints are just the connection. A port is a single
> data flow, so 2 endpoints on a port reflect 2 possible connections for
> that data flow.
> 
> > +child node can take over parent node type. below example indicates
> > +device0 type is "typeA" && "typeB",
> > +device1 type is "typeA" && "typeB" && "typeC".
> 
> This does not make sense to me. A concrete example perhaps using HDMI
> audio would be helpful.

"type" on "port" only is OK. I will fix that.

Multi type feature (= take over from parent) and type on "endpoint"
is not urgent at this point, so I will drop these in v2.
I just thought that it will be necessary in the future.