linux-kernel - Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 11:28:17 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

Hi Paul,

On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> menuconfig PM_DEVFREQ_EVENT
> 	bool "DEVFREQ-Event device Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/devfreq/devfreq-event.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

Regards,
Chanwoo Choi