linux-kernel - Re: [PATCH v4 5/8] spi: add support for ACPI reconfigure notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 15:17:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Octavian Purdila <octavian.purdila@...el.com>
Cc:	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Wolfram Sang <wsa@...-dreams.de>,
	Joel Becker <jlbec@...lplan.org>, linux-acpi@...r.kernel.org,
	linux-efi@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	irina.tirdea@...el.com, leonard.crestez@...el.com
Subject: Re: [PATCH v4 5/8] spi: add support for ACPI reconfigure
 notifications

On Fri, Jun 17, 2016 at 02:52:13PM +0300, Octavian Purdila wrote:

> This patch adds supports for SPI device enumeration and removal via
> ACPI reconfiguration notifications that are send as a result of an
> ACPI table load or unload operation.

I still have the same concern I've had all the way through here: this is
very similar to the equivalent DT code but not quite, especially in
regard to the OF_POPULATED flag which has no ACPI equivalent.  This
gives us ACPI code which just looks like it's missing something.  I'd
like to see the comparison at least covered in the changelog so people
have something to refer to in future when trying to understand why
things are done this way.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)