linux-kernel - Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 17:43:18 -0300
From:	Adhemerval Zanella <adhemerval.zanella@...aro.org>
To:	Yury Norov <ynorov@...iumnetworks.com>,
	Joseph Myers <joseph@...esourcery.com>
Cc:	libc-alpha@...rceware.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, catalin.marinas@....com, marcus.shawcroft@....com,
	philb@....org, davem@...emloft.net, szabolcs.nagy@....com,
	maxim.kuvyrkov@...aro.org, pinskia@...il.com,
	bamvor.zhangjian@...wei.com, schwab@...e.de, fweimer@...hat.com,
	Prasun.Kapoor@...ium.com, cmetcalf@...lanox.com,
	hjl.tools@...il.com
Subject: Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port



On 28/06/2016 14:59, Yury Norov wrote:
> On Tue, Jun 28, 2016 at 05:18:04PM +0000, Joseph Myers wrote:
>> On Tue, 28 Jun 2016, Yury Norov wrote:
>>
>>> aarch64 and ilp32 has different size of time_t. So to have common
>>> layout for struct utmp and utmpx, corresponding headers are taken
>>> from s390 port.
>>
>> You can't #include installed headers from other ports like this; it 
>> wouldn't work when using an installed library.
>>
>> -- 
>> Joseph S. Myers
>> joseph@...esourcery.com
> 
> So I should copy? Hmm...
> 

In this case yes, since the reference will be broken because the s390
won't be installed.