linux-kernel - Re: [PATCH] USB: dwc2-usb: add USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 18:54:54 -0700
From:	John Youn <John.Youn@...opsys.com>
To:	Arnd Bergmann <arnd@...db.de>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:	John Youn <John.Youn@...opsys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: dwc2-usb: add USB_GADGET dependency

On 6/24/2016 12:28 AM, Arnd Bergmann wrote:
> The driver selects NOP_USB_XCEIV, which can only be built-in if
> USB_GADGET is either disabled or also built-in, so with USB_DWC2_PCI=y
> and USB_GADGET=m, NOP_USB_XCEIV is also built-in and we get this link
> error:
> 
> drivers/usb/built-in.o: In function `nop_set_peripheral':
> (text+0x1927c): undefined reference to `usb_gadget_vbus_connect'
> drivers/usb/built-in.o: In function `nop_gpio_vbus_thread':
> (text+0x197a0): undefined reference to `usb_gadget_vbus_connect'
> (text+0x19830): undefined reference to `usb_gadget_vbus_disconnect'
> 
> This adds the same dependency for the dwc2 driver to avoid that
> broken configuration.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/usb/dwc2/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
> index c1f29caa8990..e838701d6dd5 100644
> --- a/drivers/usb/dwc2/Kconfig
> +++ b/drivers/usb/dwc2/Kconfig
> @@ -55,6 +55,7 @@ endchoice
>  config USB_DWC2_PCI
>  	tristate "DWC2 PCI"
>  	depends on PCI
> +	depends on USB_GADGET || !USB_GADGET
>  	default n
>  	select NOP_USB_XCEIV
>  	help
> 

Acked-by: John Youn <johnyoun@...opsys.com>


John