linux-kernel - Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in

Open Source and information security mailing list archives

Date:	Wed, 29 Jun 2016 11:35:57 +0800
From:	Yakir Yang <ykk@...k-chips.com>
To:	Sean Paul <seanpaul@...omium.org>
Cc:	Mark Yao <yzq@...k-chips.com>, Inki Dae <inki.dae@...sung.com>,
	Jingoo Han <jingoohan1@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-rockchip@...ts.infradead.org,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Emil Velikov <emil.l.velikov@...il.com>,
	Douglas Anderson <dianders@...omium.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Javier Martinez Canillas <javier@....samsung.com>,
	Tomasz Figa <tomasz.figa@...omium.com>,
	Stéphane Marchesin <marcheu@...omium.org>,
	Thierry Reding <treding@...dia.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event
 when panel plug in

Sean,

On 06/23/2016 10:24 PM, Sean Paul wrote:
> On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <ykk@...k-chips.com> wrote:
>> The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only
>> send drm hp event when the irq_type and the enum value is true.
>>
>> if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...)
>>          drm_helper_hpd_irq_event(dp->drm_dev);
>>
>> So there would no drm hpd event when cable plug in, to fix that
>> just need to assign all hotplug enum with no-zero values.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>> Signed-off-by: Yakir Yang <ykk@...k-chips.com>
>> Reviewed-by: Stéphane Marchesin <marcheu@...omium.org>
>> Tested-by: Javier Martinez Canillas <javier@....samsung.com>
> Reviewed-by: Sean Paul <seanpaul@...omium.org>
>

Thanks  ;)

>> ---
>> Changes in v3:
>> - Add reviewed flag from Stéphane.
>>      [https://chromium-review.googlesource.com/#/c/346319/15]
>> - Add tested flag from Javier
>>
>> Changes in v2: None
>>
>>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
>> index f09275d..b456380 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h
>> @@ -127,10 +127,10 @@ enum analog_power_block {
>>   };
>>
>>   enum dp_irq_type {
>> -       DP_IRQ_TYPE_HP_CABLE_IN,
>> -       DP_IRQ_TYPE_HP_CABLE_OUT,
>> -       DP_IRQ_TYPE_HP_CHANGE,
>> -       DP_IRQ_TYPE_UNKNOWN,
>> +       DP_IRQ_TYPE_HP_CABLE_IN  = BIT(0),
>> +       DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1),
>> +       DP_IRQ_TYPE_HP_CHANGE    = BIT(2),
>> +       DP_IRQ_TYPE_UNKNOWN      = BIT(3),
>>   };
>>
>>   struct video_info {
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives