linux-kernel - Re: [PATCH] platform/x86: Add IIO dependency to ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 23:21:39 -0600
From:	Azael Avalos <coproscefalo@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 23:16 GMT-06:00 Darren Hart <dvhart@...radead.org>:
> On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote:
>> The toshiba_acpi driver added support to the accelerometer axis
>> via the IIO subsystem, but failed to add the dependency to the
>> Kconfig file, making the driver fail to compile if the IIO
>> subsystem is not selected.
>>
>> This patch adds a depedency to the IIO subsystem to the
>> ACPI_TOSHIBA entry in Kconfig to avoid such build failure.
>>
>> Signed-off-by: Azael Avalos <coproscefalo@...il.com>
>> ---
>> Darren, Jonathan:
>>  I just received a few mails from the kbuild test robot informing
>>  the build failure, as a fix for this I just added a hard dependency
>>  to IIO, but maybe Jonathan can weigh in and provide me with a better
>>  alternative (perhaps some ifdefs) as to the hard IIO dependency.
>
> Don't you just love the giant kernel builder in the sky?

I certainly do, the ever watching eye XD

>
> Rather than add this separately and leave a potential build failure in the
> kernel, I'll add this line to:
>
> toshiba_acpi: Add IIO interface for accelerometer axis data

Great :-)

>
>>
>>  drivers/platform/x86/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index c06bb85..633fc5c 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -669,6 +669,7 @@ config ACPI_TOSHIBA
>>       depends on SERIO_I8042 || SERIO_I8042 = n
>>       depends on ACPI_VIDEO || ACPI_VIDEO = n
>>       depends on RFKILL || RFKILL = n
>> +     depends on IIO
>>       select INPUT_POLLDEV
>>       select INPUT_SPARSEKMAP
>>       ---help---
>> --
>> 2.8.4
>>
>>
>
> --
> Darren Hart
> Intel Open Source Technology Center



-- 
-- El mundo apesta y vosotros apestais tambien --