linux-kernel - Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch removed from -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2016 16:34:24 +0900
From:	Joonsoo Kim <iamjoonsoo.kim@....com>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	rientjes@...gle.com, hughd@...gle.com, mgorman@...hsingularity.net,
	minchan@...nel.org, stable@...r.kernel.org,
	mm-commits@...r.kernel.org
Subject: Re: [merged] mm-compaction-abort-free-scanner-if-split-fails.patch
 removed from -mm tree

On Wed, Jun 29, 2016 at 12:05:09PM +0200, Vlastimil Babka wrote:
> On 06/29/2016 10:12 AM, Joonsoo Kim wrote:
> >>@@ -1035,8 +1034,12 @@ static void isolate_freepages(struct com
> >> 			continue;
> >>
> >> 		/* Found a block suitable for isolating free pages from. */
> >>-		isolate_freepages_block(cc, &isolate_start_pfn,
> >>-					block_end_pfn, freelist, false);
> >>+		isolated = isolate_freepages_block(cc, &isolate_start_pfn,
> >>+						block_end_pfn, freelist, false);
> >>+		/* If isolation failed early, do not continue needlessly */
> >>+		if (!isolated && isolate_start_pfn < block_end_pfn &&
> >>+		    cc->nr_migratepages > cc->nr_freepages)
> >>+			break;
> >
> >Hello, David.
> >
> >Minchan found the bug on this patch.
> 
> Was it reported in some mail to linux-mm before the patch was sent
> to Linus, or just now?

Unfortunately, we found it yesterday and discussed it in offline.

Thanks.