linux-kernel - Re: [PATCH] ALSA: riptide: Use DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2016 11:14:36 +0900
From:	Takashi Sakamoto <o-takashi@...amocchi.jp>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>, perex@...ex.cz,
	tiwai@...e.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Cc:	julia.lawall@...6.fr
Subject: Re: [PATCH] ALSA: riptide: Use DIV_ROUND_UP

On Jun 29 2016 23:56, Amitoj Kaur Chawla wrote:
> The kernel.h macro DIV_ROUND_UP performs the computation
> (((n) + (d) - 1) /(d)) but is perhaps more readable.
>
> The Coccinelle script used to make this change is as follows:
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression n,d;
> @@
>
> (
> - (n + d - 1) / d
> + DIV_ROUND_UP(n,d)
> |
> - (n + (d - 1)) / d
> + DIV_ROUND_UP(n,d)
> )
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>   sound/pci/riptide/riptide.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index 94639d6..067a912 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -1496,7 +1496,7 @@ static int snd_riptide_prepare(struct snd_pcm_substream *substream)
>   		f = PAGE_SIZE;
>   		while ((size + (f >> 1) - 1) <= (f << 7) && (f << 1) > period)
>   			f = f >> 1;
> -		pages = (size + f - 1) / f;
> +		pages = DIV_ROUND_UP(size, f);
>   		data->size = size;
>   		data->pages = pages;
>   		snd_printdd
>

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>


Regards

Takashi Sakamoto