linux-kernel - Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2016 14:20:14 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Songjun Wu <songjun.wu@...el.com>,
	laurent.pinchart@...asonboard.com, nicolas.ferre@...el.com,
	boris.brezillon@...e-electrons.com,
	alexandre.belloni@...e-electrons.com, robh@...nel.org
Cc:	linux-arm-kernel@...ts.infradead.org,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Niklas SÃ¶derlund 
	<niklas.soderlund+renesas@...natech.se>,
	Richard Röjfors <richard@...finpack.se>,
	Benoit Parrot <bparrot@...com>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org,
	Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-media@...r.kernel.org,
	Simon Horman <horms+renesas@...ge.net.au>
Subject: Re: [PATCH v5 0/2] [media] atmel-isc: add driver for Atmel ISC

Hi Songjun,

First of all, please CC patch 2/2 to linux-media as well the next time you post this.
I only see 1/2 on the mailinglist, and we need both.

Secondly, before I can accept it you need to run the v4l2-compliance test first and
I need to see the output of that test.

The compliance test is here: https://git.linuxtv.org/v4l-utils.git. Always compile it from
the repository so you know you are using the latest most up to date version.

Since this driver supports multiple pixelformats you need to test with the -f option,
which tests streaming for all pixelformats.

Obviously, there shouldn't be any FAILs :-)

I greatly simplifies the code review if I know it passes the compliance test.

Regards,

	Hans