linux-kernel - Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2016 10:09:44 +0800
From:	wangyijing <wangyijing@...wei.com>
To:	Coly Li <i@...y.li>, <axboe@...com>,
	Kent Overstreet <kent.overstreet@...il.com>
CC:	Eric Wheeler <git@...ux.ewheeler.net>, Coly Li <colyli@...e.de>,
	<linux-bcache@...r.kernel.org>, <linux-raid@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for
 cache_alloc()



在 2016/6/29 18:20, Coly Li 写道:
> 在 16/6/22 上午10:10, Yijing Wang 写道:
>> Cache_sb is not used in cache_alloc, and we have copied
>> sb info to cache->sb already, remove it.
>>
>> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
>> ---
>>  drivers/md/bcache/super.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index f5dbb4e..aecaace 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj)
>>  	module_put(THIS_MODULE);
>>  }
>>  
>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca)
>> +static int cache_alloc(struct cache *ca)
>>  {
>>  	size_t free;
>>  	struct bucket *b;
>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page,
>>  	if (blk_queue_discard(bdev_get_queue(ca->bdev)))
>>  		ca->discard = CACHE_DISCARD(&ca->sb);
>>  
>> -	ret = cache_alloc(sb, ca);
>> +	ret = cache_alloc(ca);
> 
> I am not sure whether struct cache_b *sb will be used in future, I
> suggest to let it be for now.
> 

We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb.

Thanks!
Yijing.

> 
> 
>>  	if (ret != 0)
>>  		goto err;
>>  
>>
> 
>