linux-kernel - Re: [PATCH] spi: spi-sh: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jul 2016 18:58:24 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	kbuild-all@...org, Mark Brown <broonie@...nel.org>,
	Tejun Heo <tj@...nel.org>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-sh: Remove deprecated
 create_singlethread_workqueue

Hi,

[auto build test ERROR on spi/for-next]
[also build test ERROR on v4.7-rc5 next-20160701]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bhaktipriya-Shridhar/spi-spi-sh-Remove-deprecated-create_singlethread_workqueue/20160702-164813
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/spi/spi-sh.c: In function 'spi_sh_remove':
>> drivers/spi/spi-sh.c:427:13: error: incompatible type for argument 1 of 'flush_work'
     flush_work(ss->ws);
                ^~
   In file included from include/linux/srcu.h:34:0,
                    from include/linux/notifier.h:15,
                    from include/linux/memory_hotplug.h:6,
                    from include/linux/mmzone.h:737,
                    from include/linux/gfp.h:5,
                    from include/linux/kmod.h:22,
                    from include/linux/module.h:13,
                    from drivers/spi/spi-sh.c:19:
   include/linux/workqueue.h:444:13: note: expected 'struct work_struct *' but argument is of type 'struct work_struct'
    extern bool flush_work(struct work_struct *work);
                ^~~~~~~~~~

vim +/flush_work +427 drivers/spi/spi-sh.c

   421	
   422	static int spi_sh_remove(struct platform_device *pdev)
   423	{
   424		struct spi_sh_data *ss = platform_get_drvdata(pdev);
   425	
   426		spi_unregister_master(ss->master);
 > 427		flush_work(ss->ws);
   428		free_irq(ss->irq, ss);
   429	
   430		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (54806 bytes)