linux-kernel - Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jul 2016 08:21:33 -0700
From:	Markus Mayer <markus.mayer@...adcom.com>
To:	Alexandre Courbot <gnurou@...il.com>
Cc:	Ben Skeggs <bskeggs@...hat.com>, David Airlie <airlied@...ux.ie>,
	Alexandre Courbot <acourbot@...dia.com>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new
 strtolower() function

On 1 July 2016 at 18:18, Alexandre Courbot <gnurou@...il.com> wrote:
> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer@...adcom.com> wrote:
>> Call strtolower() rather than walking the string explicitly to convert
>> it to lowercase.
>>
>> Signed-off-by: Markus Mayer <mmayer@...adcom.com>
>> ---
>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> index 34ecd4a..c50594c 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname,
>>  {
>>         char f[64];
>>         char cname[16];
>> -       int i;
>>
>>         /* Convert device name to lowercase */
>>         strncpy(cname, device->chip->name, sizeof(cname));
>>         cname[sizeof(cname) - 1] = '\0';
>> -       i = strlen(cname);
>> -       while (i) {
>> -               --i;
>> -               cname[i] = tolower(cname[i]);
>> -       }
>> +       strtolower(cname);
>
> This function doesn't seem to exist as of next-20160701, where have
> you found it?

I didn't find it. I wrote it, because it didn't exist and I needed it.
See: https://lkml.org/lkml/2016/6/30/727 and
https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
series).