linux-kernel - Re: [PATCH v3 01/21] backports: move legacy and SmPL patch application into helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Jul 2016 11:33:03 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	backports@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, yann.morin.1998@...e.fr,
	mmarek@...e.cz, sassmann@...nic.de,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH v3 01/21] backports: move legacy and SmPL patch
 application into helper

On Tue, 2014-11-11 at 00:14 -0800, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@...e.com>
> 
> This allows us to extend how backports uses patches for
> different types of applications. This will later be used
> for kernel integration support, for example.
> 
> This should have no functional change.

Obviously this patch was applied a long time ago, but you lied - it has
a functional change:

> +        if process.returncode != 0:
> +            if not args.verbose:
> +                logwrite("Failed to apply changes from %s" %
> print_name)
> +                for line in output:
> +                    logwrite('> %s' % line)
> +            raise Exception('Patch failed')

vs.

> -        if process.returncode != 0:
> -            if not args.verbose:
> -                logwrite("Failed to apply changes from %s" %
> print_name)
> -                for line in output:
> -                    logwrite('> %s' % line)
> -            return 2

This had a major impact on the devel/git-tracker.py tool.

johannes