linux-kernel - Re: [RFC RESEND PATCH] swap: choose swap device according to numa node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jul 2016 13:57:35 +0800
From:	Yu Chen <yu.chen.surf@...il.com>
To:	Aaron Lu <aaron.lu@...el.com>
Cc:	Linux Memory Management List <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC RESEND PATCH] swap: choose swap device according to numa node

On Tue, Jul 5, 2016 at 11:19 AM, Aaron Lu <aaron.lu@...el.com> wrote:
> Resend:
> This is a resend, the original patch doesn't catch much attention.
> It may not be a big deal for swap devices that used to be hosted on
> HDD but with devices like 3D Xpoint to be used as swap device, it could
> make a real difference if we consider NUMA information when doing IO.
> Comments are appreciated, thanks for your time.
>
-------------------------%<-------------------------
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 71b1c29948db..dd7e44a315b0 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3659,9 +3659,11 @@ void kswapd_stop(int nid)
>
>  static int __init kswapd_init(void)
>  {
> -       int nid;
> +       int nid, err;
>
> -       swap_setup();
> +       err = swap_setup();
> +       if (err)
> +               return err;
>         for_each_node_state(nid, N_MEMORY)
>                 kswapd_run(nid);
>         hotcpu_notifier(cpu_callback, 0);
In original implementation, although swap_setup failed,
the swapd would also be created, since swapd is
not only  used for swap out but also for other page reclaim,
so this change above might modify its semantic? Sorry if
I understand incorrectly.