linux-kernel - Re: [RFC PATCH v1] irqchip: add support for SMP irq router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jul 2016 18:13:34 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Sebastian Frias <sf84@...oste.net>,
	Jason Cooper <jason@...edaemon.net>
Cc:	Mason <slash.tmp@...e.fr>, LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH v1] irqchip: add support for SMP irq router

On 05/07/16 17:59, Sebastian Frias wrote:
> Hi Marc,
> 
> On 07/05/2016 06:48 PM, Marc Zyngier wrote:
>>> I already did something like that, you can see it here:
>>>
>>> https://marc.info/?l=linux-kernel&m=146592235919308&w=2
>>>
>>> the problem with that code is that it cannot handle more than 24 IRQs (the
>>> number of outputs of the router), because they are not being shared.
>>>
>>> Maybe I need a sort of hybrid approach by reintroducing part of
>>> "irq-crossbar.c" code to replace the irq domain layout that is currently
>>> being done using DT properties ?
>>>
>>> However, I have not seen any examples of how to describe, using the DT,
>>> an association between a device HW irq, and the GIC hwirq where it goes to,
>>> nor how to express in the DT that multiple devices should share a given GIC
>>> hwirq.
>>> Basically, when a device requests the IRQ specified in its DT, I need:
>>> - to know which GIC hwirq line should I route it to (or the GIC to tell
>>> me which one it expects)
>>
>> You really don't need to describe this. The configuration that is
>> applied to your router in entirely under software control,
> 
> With "entirely under software control" do you mean this driver's code?

Yes.

> 
>> and none of
>> that should appear in the DT. You could decide to mux all the interrupts
>> to a single one, or decide that the 23 first interrupts you discover get
>> their own private line to the GIC and that everything else is muxed.
>>
>> So given that this is completely defined by software, it has no place in
>> DT. 
> 
> I think I'm missing something, what is the difference between the domains
> described by nodes in the DT for irq-tango.c (arch/arm/boot/dts/tango4-common.dtsi)
> and the DT from my RFC?

The fundamental difference is that with your new fancy controller, you
can decide what is going where, while the previous one is completely set
in stone (the output line is a direct function of the input line).

> 
> Alternatively, the previous DT (arch/arm/boot/dts/tango4-common.dtsi) allowed
> IRQ sharing to be specified in the DT, is that wrong?
> 
>> There may not be an example of such an interrupt controller in the
>> tree, but this doesn't look too hard to implement.
> 
> Well, if you the domains should not be described in the DT and that they should
> be somehow hardcoded into the drivers' code, it should not be hard indeed.

Hardcoded? No way. You simply implement a route allocator in your
driver, assigning them as needed. And yes, if you have more than 24
interrupts, they get muxed.

	M.
-- 
Jazz is not dead. It just smells funny...