linux-kernel - [PATCH v6 17/18] dmaengine: st_fdma: Change to late_initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  6 Jul 2016 09:54:35 +0100
From:	Peter Griffin <peter.griffin@...aro.org>
To:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...inux.com, vinod.koul@...el.com, patrice.chotard@...com,
	bjorn.andersson@...aro.org, ohad@...ery.com
Cc:	peter.griffin@...aro.org, lee.jones@...aro.org,
	dmaengine@...r.kernel.org, devicetree@...r.kernel.org
Subject: [PATCH v6 17/18] dmaengine: st_fdma: Change to late_initcall_sync

This avoids unnecessary rounds of -EPROBE_DEFER, which
in turn avoids lots of console noise from remoteproc when
all drivers are built-in.

Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
---
 drivers/dma/st_fdma.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index f28026e..df7af95 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -869,10 +869,22 @@ static struct platform_driver st_fdma_platform_driver = {
 		.name = "st-fdma",
 		.of_match_table = st_fdma_match,
 	},
-	.probe = st_fdma_probe,
-	.remove = st_fdma_remove,
 };
-module_platform_driver(st_fdma_platform_driver);
+
+static int __init fdma_init(void)
+{
+	return platform_driver_probe(&st_fdma_platform_driver, st_fdma_probe);
+}
+
+static void __exit fdma_exit(void)
+{
+	platform_driver_unregister(&st_fdma_platform_driver);
+}
+
+/* attempt to load late, helps when built-in */
+
+late_initcall_sync(fdma_init);
+module_exit(fdma_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("STMicroelectronics FDMA engine driver");
-- 
1.9.1