linux-kernel - Re: [PATCH v2] pinctrl: Add STM32F746 MCU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 14:43:12 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Alexandre TORGUE <alexandre.torgue@...com>
Cc:	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Patrice Chotard <patrice.chotard@...com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: Add STM32F746 MCU support

On Wed, Jul 6, 2016 at 11:46 AM, Alexandre TORGUE
<alexandre.torgue@...com> wrote:

> This patch which adds STM32F746 pinctrl and GPIO support, relies on the
> generic STM32 pinctrl driver.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@...com>

(...)
> +static struct platform_driver stm32f746_pinctrl_driver = {
> +       .probe = stm32_pctl_probe,
> +       .driver = {
> +               .name = "stm32f746-pinctrl",
> +               .of_match_table = stm32f746_pctrl_match,
> +       },
> +};
> +
> +static int __init stm32f746_pinctrl_init(void)
> +{
> +       return platform_driver_register(&stm32f746_pinctrl_driver);
> +}
> +device_initcall(stm32f746_pinctrl_init);

Please use builtin_platform_driver() for this.

Yours,
Linus Walleij