linux-kernel - Re: [PATCH] pinctrl: imx21: include linux/module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 09:21:39 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Fabio Estevam <festevam@...il.com>
CC:	Arnd Bergmann <arnd@...db.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Laxman Dewangan <ldewangan@...dia.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: imx21: include linux/module.h

[Re: [PATCH] pinctrl: imx21: include linux/module.h] On 06/07/2016 (Wed 10:15) Fabio Estevam wrote:

> Hi Arnd,
> 
> On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann <arnd@...db.de> wrote:
> > The pinctrl driver includes a device table, but the macro used for
> > declaring it is declared in a header that is not visible here:
> >
> > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
> >  MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> >
> > This adds the missing include.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
> 
> I think the correct fix here would be:
> 
> --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
>         { .compatible = "fsl,imx21-iomuxc", },
>         { }
>  };
> -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> 
>  static struct platform_driver imx21_pinctrl_driver = {
>         .driver = {
> 
> 
> If you agree I can send a formal patch.

Yes, deleting the MODULE_DEVICE_TABLE is the right fix.  I'm curious why
that never showed up in all the build coverage I did...

Paul.
--