linux-kernel - Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 18:16:59 +0100
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Vinay Simha <simhavcs@...il.com>
Cc:	Archit Taneja <archit.taneja@...il.com>,
	Rob Clark <robdclark@...il.com>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	John Stultz <john.stultz@...aro.org>,
	Thierry Reding <thierry.reding@...il.com>,
	David Airlie <airlied@...ux.ie>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

On 4 July 2016 at 07:27, Vinay Simha <simhavcs@...il.com> wrote:
> On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov <emil.l.velikov@...il.com> wrote:
>> On 28 June 2016 at 16:59, Vinay Simha <simhavcs@...il.com> wrote:
>>> hi,
>>>
>>> Any further comments or reviews?
>>>
>> You still haven't covered my earlier suggestions, as such I cannot
>> give you a r-b :-( They are not blockers by any means, but it'll be
>> up-to the maintainer to ack/pick this up.
> i do have covered the suggestions from you.
> As i had mentioned earlier we cannot drop few returns and keep it
> void(drm_panel_funcs - unprepare), since drm framework requires
> return. if do you have any alternate solution please suggest, will
> incorporate.
Please re-read what I said. I don't recall suggesting changes to the
vfunc signature but the helper that you're calling. Why ? Because it's
uncommon/unwise to prematurely exit during the teardown/destructor
stage.

Although as said previously, its nothing serious, hence why people
rarely bother.
-Emil