linux-kernel - Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2016 20:24:18 -0400
From:	Joseph Salisbury <joseph.salisbury@...onical.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	hdegoede@...hat.com, adrienverge@...il.com, yaowen@...gle.com,
	vpalatin@...omium.org, stern@...land.harvard.edu,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan
 Microelectronics Touchpad

On 07/06/2016 07:10 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power Management so 
>> adding a quirk.  This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@...onical.com>
>> Cc: stable <stable@...r.kernel.org>
>>
>> ---
>>  drivers/usb/core/quirks.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..a33d003 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>>  	/* Protocol and OTG Electrical Test Device */
>>  	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>> +
>> +	/* ELAN Microelectronics Touchscreen */
>> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
> Please put this next to the other Elan touchscreen quirk entries, don't
> put them in random order, it's a pain to maintain that way...
>
> thanks,
>
> greg k-h
Sorry, I grouped it with the other USB_QUIRK_NO_LPM entries.  I'll send
a V2 patch and make a note to group by manufacturer from now on.

Thanks,

Joe