linux-kernel - [PATCH] xen-fbfront: prefer xenbus_write() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2016 01:50:05 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<plagnioj@...osoft.com>, <tomi.valkeinen@...com>
Cc:	<david.vrabel@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>, "Juergen Gross" <JGross@...e.com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] xen-fbfront: prefer xenbus_write() over
 xenbus_printf() where possible

... as being the simpler variant.

Signed-off-by: Jan Beulich <jbeulich@...e.com>
---
 drivers/video/fbdev/xen-fbfront.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- 4.7-rc6-prefer-xenbus_write.orig/drivers/video/fbdev/xen-fbfront.c
+++ 4.7-rc6-prefer-xenbus_write/drivers/video/fbdev/xen-fbfront.c
@@ -593,11 +593,11 @@ static int xenfb_connect_backend(struct
 			    evtchn);
 	if (ret)
 		goto error_xenbus;
-	ret = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
-			    XEN_IO_PROTO_ABI_NATIVE);
+	ret = xenbus_write(xbt, dev->nodename, "protocol",
+			   XEN_IO_PROTO_ABI_NATIVE);
 	if (ret)
 		goto error_xenbus;
-	ret = xenbus_printf(xbt, dev->nodename, "feature-update", "1");
+	ret = xenbus_write(xbt, dev->nodename, "feature-update", "1");
 	if (ret)
 		goto error_xenbus;
 	ret = xenbus_transaction_end(xbt, 0);