linux-kernel - Re: [PATCH] clk: stm32f4: fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Jul 2016 17:55:44 -0700
From:	Michael Turquette <mturquette@...libre.com>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	sboyd@...eaurora.org, mcoquelin.stm32@...il.com
Cc:	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	"Christophe JAILLET" <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] clk: stm32f4: fix error handling

Quoting Christophe JAILLET (2016-07-02 23:06:43)
> This is likely that checking 'clks[idx]' instead of 'clks[n]' is
> expected here.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.

Regards,
Mike

> ---
>  drivers/clk/clk-stm32f4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
> index b6ca33f..02d6810 100644
> --- a/drivers/clk/clk-stm32f4.c
> +++ b/drivers/clk/clk-stm32f4.c
> @@ -364,7 +364,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
>                     NULL, gd->name, gd->parent_name, gd->flags,
>                     base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
>  
> -               if (IS_ERR(clks[n])) {
> +               if (IS_ERR(clks[idx])) {
>                         pr_err("%s: Unable to register leaf clock %s\n",
>                                np->full_name, gd->name);
>                         goto fail;
> -- 
> 2.7.4
>