linux-kernel - [patch] ocfs2: silence an integer overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 11:12:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mark Fasheh <mfasheh@...e.com>
Cc:	Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [patch] ocfs2: silence an integer overflow warning

My static checker complains that ->me_start + ->me_len can overflow.
I haven't followed it through to see the implications but it seems
simple enough to prevent the overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
move_extents in other less common file systems have this same warning as
well.

diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c
index e3d05d9..9ff405a 100644
--- a/fs/ocfs2/move_extents.c
+++ b/fs/ocfs2/move_extents.c
@@ -1014,7 +1014,8 @@ int ocfs2_ioctl_move_extents(struct file *filp, void __user *argp)
 		goto out_free;
 	}
 
-	if (range.me_start > i_size_read(inode)) {
+	if (range.me_start > i_size_read(inode) ||
+	    range.me_len > i_size_read(inode)) {
 		status = -EINVAL;
 		goto out_free;
 	}