linux-kernel - Re: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 11:26:02 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Jan Beulich <JBeulich@...e.com>,
	Roger Pau Monne <roger.pau@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over
 xenbus_printf() where possible

On 07/07/16 09:06, Jan Beulich wrote:
> ... as being the simpler variant.
[...]
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkback/xenbus.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkback/xenbus.c
> @@ -617,9 +617,9 @@ static int xen_blkbk_probe(struct xenbus
>  		goto fail;
>  	}
>  
> -	err = xenbus_printf(XBT_NIL, dev->nodename,
> -			    "feature-max-indirect-segments", "%u",
> -			    MAX_INDIRECT_SEGMENTS);
> +	err = xenbus_write(XBT_NIL, dev->nodename,
> +			   "feature-max-indirect-segments",
> +			   __stringify(MAX_INDIRECT_SEGMENTS));

Yuk :(

Now someone has to check both __stringify() and MAX_INDIRECT_SEGMENTS to
work out what this actually looks like.

David