linux-kernel - Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 12:04:53 +0100
From:	Eric Engestrom <eric.engestrom@...tec.com>
To:	Markus Mayer <mmayer@...adcom.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Chris Metcalf <cmetcalf@...hip.com>,
	Kees Cook <keescook@...omium.org>,
	<devel@...verdev.osuosl.org>, <linux-scsi@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <nouveau@...ts.freedesktop.org>,
	<speakup@...ux-speakup.org>, <linux-kernel@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-acpi@...r.kernel.org>,
	<target-devel@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

On Tue, Jul 05, 2016 at 01:47:05PM -0700, Markus Mayer wrote:
> All functions return a pointer to the terminating '\0' character in the
> modified string ("dst" or "s", respectively).

I think this is going to be confusing. From the man:

	The strcpy() and strncpy() functions return a pointer to the
	destination string dest.

I think it would be better to keep the same behaviour, especially since
you used the same name for your functions (which I think is sensible),
not to mention you don't use this return value in any of your calls.
(IMHO strcpy() shouldn't have had a return value and neither should your
functions, but since it does, yours should match.)

Cheers,
  Eric