linux-kernel - Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 12:36:48 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Jan Beulich <JBeulich@...e.com>, <david.vrabel@...rix.com>,
	<boris.ostrovsky@...cle.com>, Juergen Gross <JGross@...e.com>
CC:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from
 xenbus_dev_request_and_reply()

On 07/07/16 08:32, Jan Beulich wrote:
> We must not skip the transaction_end() call for a failed
> XS_TRANSACTION_START. The removed code fragment got introduced by
> commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus
> stalling shutdown/restart") without its description really indicating
> why it was added (and hence I can't identify whether a more complex
> change might be needed here).

If sending the XS_TRANSACTION_END message failed, then the transaction
is still open and transaction_end() should not be called.

However, if sending an XS_TRANSACTION_START failed, then
transaction_end() should be called.

So, yes a more complex fix is needed here.

David