linux-kernel - Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 11:37:51 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Andrew Cooper <andrew.cooper3@...rix.com>
Cc:	Roger Pau Monne <roger.pau@...rix.com>,
	Jan Beulich <JBeulich@...e.com>,
	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct
 attribute_group"

On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> > Acked-by: Roger Pau Monné <roger.pau@...rix.com>
> >
> > Although the wording in the commit message looks weird to me, but I'm not a 
> > native speaker anyway.
> 
> As a native speaker, I can't parse it either.
> 
> I think s/such/these/ is needed.

The functions such as these have been taking pointers to const
since at least 2.6.16. 

?
> 
> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xen.org
> https://lists.xen.org/xen-devel