linux-kernel - Re: [PATCH 1/2] i2c-dev: don't get i2c adapter via i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jul 2016 10:31:54 +0900
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	Johan Hovold <johan@...nel.org>, Alex Elder <elder@...aro.org>
Subject: Re: [PATCH 1/2] i2c-dev: don't get i2c adapter via i2c_dev

On Tue, Jul 05, 2016 at 07:57:06PM -0700, Viresh Kumar wrote:
> There is no code protecting i2c_dev to be freed after it is returned
> from i2c_dev_get_by_minor() and using it to access the value which we
> already have (minor) isn't safe really.
> 
> Avoid using it and get the adapter directly from 'minor'.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied to for-next, thanks!

Jean, thanks for providing the background information! That was exactly
the missing piece for me.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)