linux-kernel - Re: [PATCH] leds: leds-gpio: Set of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 09:34:30 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	"open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: leds-gpio: Set of_node for created LED devices

Hi Rafał,

Thanks for the patch.

On 07/08/2016 02:53 PM, Rafał Miłecki wrote:
> When working with Device Tree we iterate over children of "gpio-leds"
> compatible node and create LED device for each of them. We take care of
> all common DT properties (label, default trigger, state, etc.), however
> some triggers may want to support more of them.
>
> It could be useful for timer trigger to support setting delay on/off
> values with Device Tree property. Or for transient trigger to support
> e.g. duration property.
>
> We obviously should handle such properties in triggers, not in generic
> code. To let trigger drivers read properties from DT node we need to set
> of_node to point the relevant node. This change allows using all kind of
> of helpers in e.g. "activate" callbacks.
>
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> ---
>   drivers/leds/leds-gpio.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 8229f06..9b991d4 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -165,6 +165,7 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
>   		return ERR_PTR(-ENOMEM);
>
>   	device_for_each_child_node(dev, child) {
> +		struct gpio_led_data *led_dat = &priv->leds[priv->num_leds];

This seems to be an unrelated change.

>   		struct gpio_led led = {};
>   		const char *state = NULL;
>
> @@ -205,12 +206,12 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
>   		if (fwnode_property_present(child, "panic-indicator"))
>   			led.panic_indicator = 1;
>
> -		ret = create_gpio_led(&led, &priv->leds[priv->num_leds],
> -				      dev, NULL);
> +		ret = create_gpio_led(&led, led_dat, dev, NULL);
>   		if (ret < 0) {
>   			fwnode_handle_put(child);
>   			goto err;
>   		}
> +		led_dat->cdev.dev->of_node = np;
>   		priv->num_leds++;
>   	}
>
>


-- 
Best regards,
Jacek Anaszewski