linux-kernel - Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 11:50:23 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, acme@...nel.org,
	adrian.hunter@...el.com, alexander.shishkin@...ux.intel.com,
	hekuang@...wei.com, jolsa@...nel.org, kan.liang@...el.com,
	mingo@...hat.com, peterz@...radead.org, wangnan0@...wei.com
Subject: Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel
 permits

On Fri, Jul 08, 2016 at 09:55:14AM +0200, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote:
> > +		if (!cpu_map__has(evsel->cpus, evlist_cpu))
> > +			continue;
> > +
> > +		cpu = cpu_map__idx(evsel->cpus, evlist_cpu);
> 
> you basicaly call cpu_map__idx twice in here,
> I think it might be better call it just once
> and check the cpu for -1

Sure, I can change the patch to do that.

Mark.