linux-kernel - Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 10:55:05 +0800
From:	Horng-Shyang Liao <hs.liao@...iatek.com>
To:	Jan Lübbe <jlu@...gutronix.de>
CC:	Rob Herring <robh+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Monica Wang <monica.wang@...iatek.com>,
	Jiaguang Zhang <jiaguang.zhang@...iatek.com>,
	Nicolas Boichat <drinkcat@...omium.org>,
	cawa cheng <cawa.cheng@...iatek.com>,
	Bibby Hsieh <bibby.hsieh@...iatek.com>,
	YT Shen <yt.shen@...iatek.com>,
	Damon Chu <damon.chu@...iatek.com>,
	<devicetree@...r.kernel.org>, Sascha Hauer <kernel@...gutronix.de>,
	"Daoyuan Huang" <daoyuan.huang@...iatek.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Glory Hung <glory.hung@...iatek.com>,
	CK HU <ck.hu@...iatek.com>,
	<linux-mediatek@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<srv_heupstream@...iatek.com>,
	Josh-YC Liu <josh-yc.liu@...iatek.com>,
	<linux-kernel@...r.kernel.org>,
	Dennis-YC Hsieh <dennis-yc.hsieh@...iatek.com>,
	Philipp Zabel <p.zabel@...gutronix.de>, <hs.liao@...iatek.com>
Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the
 MediaTek GCE unit

Hi Jan,

On Fri, 2016-07-08 at 12:17 +0200, Jan Lübbe wrote:
> On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote:
> [...]
> > +Required properties:
> > +- compatible: Must be "mediatek,mt8173-gce"
> > +- reg: Address range of the GCE unit
> > +- interrupts: The interrupt signal from the GCE block
> > +- clock: Clocks according to the common clock binding
> > +- clock-names: Must be "gce" to stand for GCE clock
> > +- #mbox-cells: Should be 1
> [...]
> > +		#mbox-cells = <1>;
> [...]
> > +		mediatek,gce = <&gce>;
> > +		mboxes = <&gce 0 1 /* main display with merging wfe */
> > +			  &gce 1 1>; /* sub display with merging wfe */
> 
> It seems that you use two cells instead of one as you declared above.
> This should be consistent.

Will correct it as 2.

> Also, why do you need an explicit phandle to the gce if you already use
> mailboxes?

"mediatek,gce" should be added to all clients which ask gce to access 
their registers.

"mboxes" should be added to all clients which will communicate with gce
via mailbox.

For example, if mmsys send cmdq tasks to ask gce to write registers of 
mmsys and ovl, mmsys should have "mediatek,gce" and "mboxes", and ovl
should have "mediatek,gce".

I will explain their difference in GCE's device tree document.

> Best regards,
> Jan Lübbe

Thanks,
HS