linux-kernel - Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2016 10:32:30 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org,
	Alexander Shiyan <shc_work@...l.ru>
Cc:	Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI

On Wednesday, July 13, 2016 11:20:00 AM CEST Alexander Shiyan wrote:
> >Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd@...db.de>:
> >
> >On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote:
> >> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
> >> > +
> >> > +An additional register is present in the system controller,
> >> > +which is assumed to be in the same device tree, with and marked
> >> > +as compatible with "cirrus,ep7209-syscon3".
> >> > +
> >> > +Example:
> >> > +
> >> > +spi@...00500 {
> >> > +     #address-cells = <1>;
> >> > +     #size-cells = <0>;
> >> > +     compatible = "cirrus,ep7209-spi";
> >> > +     reg = <0x80000500 0x4>;
> >> > +     interrupts = <15>;
> >> > +     clocks = <&clks CLPS711X_CLK_SPI>;
> >> > +     status = "disabled";
> >> > +};
> >> > +
> >> > +syscon3: syscon@...02200 {
> >> 
> >> This looks like it shouldn't be here.
> >
> >The label, or the entire node?
> 
> I think that the whole syscon3 node is redundant.

The node is needed here because it is required for the device to
work: the binding doesn't contain a label for the syscon reference
but as I documented above, any driver will have to look up the
syscon by compatible string.

	Arnd