linux-kernel - Re: [PATCH v6 17/46] infiniband: dma-mapping: Use unsigned long for dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2016 17:56:55 +0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	<linux-kernel@...r.kernel.org>, <hch@...radead.org>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	<linux-rdma@...r.kernel.org>
Subject: Re: [PATCH v6 17/46] infiniband: dma-mapping: Use unsigned long for
 dma_attrs

On 07/13/2016 05:47 PM, Krzysztof Kozlowski wrote:
> On 07/13/2016 12:37 PM, Bart Van Assche wrote:
>> On 07/13/2016 03:41 PM, Krzysztof Kozlowski wrote:
>>> Split out subsystem specific changes for easier reviews. This will be
>>> squashed with main commit.
>>
>> Apparently my comment has been ignored
>> (http://thread.gmane.org/gmane.linux.ports.m68k/8746/focus=37703). Are
>> you aware that you are expected to reply to feedback on patches?
>
> Of course your comment was not ignored. I am sorry that you have such
> impression. However I thought you are referring only to local variable
> which name I changed.
>
> Do you want me to rename also the argument in the ib_dma_map_sg_attrs()
> and ib_dma_unmap_sg_attrs() functions?

Hello Krzysztof,

Sorry if I was not clear enough in the comment I had posted in reply to 
the previous version of this patch series. In my comment I wanted indeed 
to refer to the name of the ib_dma_map_sg_attrs() / 
ib_dma_unmap_sg_attrs() function argument. An argument with the name 
"attrs" namely does not explain what kind of attributes that argument 
refers to ...

Thanks,

Bart.