linux-kernel - Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2016 15:07:15 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Fenghua Yu <fenghua.yu@...el.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <h.peter.anvin@...el.com>,
	Tony Luck <tony.luck@...el.com>, Tejun Heo <tj@...nel.org>,
	Borislav Petkov <bp@...e.de>,
	Stephane Eranian <eranian@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	David Carrillo-Cisneros <davidcc@...gle.com>,
	Ravi V Shankar <ravi.v.shankar@...el.com>,
	Vikas Shivappa <vikas.shivappa@...ux.intel.com>,
	Sai Prakhya <sai.praneeth.prakhya@...el.com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per
 resources

On Tue, 12 Jul 2016, Fenghua Yu wrote:

> From: Fenghua Yu <fenghua.yu@...el.com>
> 
> QoS mask MSRs array is per cache. We need to allocate CLOSID per cache
> instead global CLOSID.
> 
> A few different resources can share same QoS mask MSRs array. For
> example, one L2 cache can share QoS MSRs with its next level
> L3 cache. A domain number represents the L2 cache, the L3 cache, the L2
> cache's shared cpumask, and the L3 cache's shared cpumask.
> 
> cctable is extended to be index by domain number so that each cache
> has its own control table.
> 
> shared_domain is introduced to cover multiple resources sharing
> CLOSID.

This patch does a dozen different things at once. Can you please split the
cleanup parts, the parts where statics are removed and the actual changes in
the representation model apart so this can be reviewed?

And while at this, please fold back thes cleanups into the original
patches. There is no point to have these changes seperate.

Thanks,

	tglx