linux-kernel - Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2016 19:01:23 +0200
From:	Pavel Machek <pavel@....cz>
To:	Chen Yu <yu.c.chen@...el.com>
Cc:	linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / hibernate: Introduce snapshot test mode for
 hibernation

Hi!

> >>and then swapon the swap device, and do a testing. This should be safer?
> >Yeah, that's the way. Read-only root is other option.
> >
> >>>I guess updating documentation would be welcome from my side,
> >>>otherwise it should be ok.
> >>OK, I'll  update the documents.
> >Just add fat warning into the documentation.
> OK.

Actually... If you could add

printk(KERN_ALERT "Hibernation image written. If you have any
filesystems mounted read-write and attempt to resume, you'll corrupt
your data. To prevent that, remove the hibernation image.\n")

...I guess that would save someone's filesystem. (Yes, very high
loglevel. If you attempt to do this from anything else then singleuser
or initrd, you are asking for problems, so... lets make sure user sees
it.)

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html