linux-kernel - RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 08:13:40 +0000
From:	Rajesh Bhagat <rajesh.bhagat@....com>
To:	Peter Chen <hzpeterchen@...il.com>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Peter Chen <peter.chen@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"kishon@...com" <kishon@...com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0
 controller



> -----Original Message-----
> From: Peter Chen [mailto:hzpeterchen@...il.com]
> Sent: Friday, July 15, 2016 12:45 PM
> To: Rajesh Bhagat <rajesh.bhagat@....com>
> Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; Peter Chen <peter.chen@....com>;
> gregkh@...uxfoundation.org; kishon@...com; robh+dt@...nel.org;
> shawnguo@...nel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0
> controller
> 
> On Tue, Jul 12, 2016 at 03:59:14AM +0000, Rajesh Bhagat wrote:
> >
> >
> > > -----Original Message-----
> > > From: Peter Chen [mailto:hzpeterchen@...il.com]
> > > Sent: Monday, July 11, 2016 12:19 PM
> > > To: Rajesh Bhagat <rajesh.bhagat@....com>
> > > Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > devicetree@...r.kernel.org; Peter Chen <peter.chen@....com>;
> > > gregkh@...uxfoundation.org; kishon@...com; robh+dt@...nel.org;
> > > shawnguo@...nel.org; linux-arm-kernel@...ts.infradead.org
> > > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq
> > > usb 2.0 controller
> > >
> > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote:
> > > > Describes the qoriq usb 2.0 controller driver binding, currently
> > > > used for LS1021A and LS1012A platform.
> > > >
> > > > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@....com>
> > > > ---
> > > > Changes in v2:
> > > >  - Adds DT binding documentation for qoriq usb 2.0 controller
> > > >  - Changed the compatible string to fsl,ci-qoriq-usb2
> > > >
> > > >  .../devicetree/bindings/usb/ci-hdrc-qoriq.txt      | 34
> > > ++++++++++++++++++++++
> > > >  1 file changed, 34 insertions(+)
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > > > new file mode 100644
> > > > index 0000000..8ad7306
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > > > @@ -0,0 +1,34 @@
> > > > +* Freescale QorIQ SoC USB 2.0 Controllers
> > > > +
> > > > +Required properties:
> > > > +- compatible: Should be "fsl,ci-qoriq-usb2"
> > > > +  Wherever applicable, the IP version of the USB controller
> > > > +should
> > > > +  also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y).
> > > > +  where, X.Y is IP version of USB controller.
> >
> > Hello Peter,
> >
> > >
> > > Why you need to add IP version at compatible string?
> > > Does it can't be read out from ID register of Identification Registers.
> > >
> >
> > I agree. Will drop this controller version thing in DTS in v3.
> >
> > > > +- reg: Should contain registers location and length
> > > > +- interrupts: Should contain controller interrupt
> > > > +- phy-names: from the *Generic PHY* bindings
> > > > +- phys: from the *Generic PHY* bindings
> > > > +- clocks: clock provider specifier
> > > > +- clock-names: shall be "usb2-clock"
> > > > +Refer to clk/clock-bindings.txt for generic clock consumer
> > > > +properties
> > > > +
> > > > +Recommended properties:
> > > > +- dr_mode: One of "host" or "peripheral".
> > >
> > > Do you support dual-role?
> > >
> >
> > Yes. We do support  both host/peripheral mode.
> >
> 

Hello Peter, 

> I mean dual-role switch. If you support that, the dr_mode should be "otg".
> 

For now, we don't support otg mode. 

Best Regards,
Rajesh Bhagat 

> --
> 
> Best Regards,
> Peter Chen