linux-kernel - Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 14:09:52 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change
 ti_get/set_serial_info function arguments

On Thu, May 12, 2016 at 10:48:54AM +0200, Mathieu OTHACEHE wrote:
> It is sufficient to pass usb_serial_port structure to ti_get_serial_info
> and ti_set_serial_info.
> 
> Also move functions above ioctl to avoid function prototyping
> and use unsigned int instead of unsigned for cwait variable.

Avoid changing things in the same patch as you move something, if moving
is at all needed.

Thanks,
Johan