linux-kernel - Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 16:01:40 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before
 updating memcg

On Fri, Jul 15, 2016 at 11:45:34PM +0900, Minchan Kim wrote:
> > +static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> > +			enum lru_list lru, unsigned long *nr_zone_taken,
> > +			unsigned long nr_taken)
> > +{
> > +#ifdef CONFIG_HIGHMEM
> 
> If you think it's really worth to optimize it for non-highmem system,
> we don't need to account nr_zone_taken in *isolate_lru_pages*
> from the beginning for non-highmem system, either.
> 

It becomes a mess of ifdefs and given the marginal overhead, I left it
for now.

-- 
Mel Gorman
SUSE Labs