linux-kernel - Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 14:34:10 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linaro-kernel@...ts.linaro.org,
	Build bot for Mark Brown <broonie@...nel.org>,
	kernel-build-reports@...ts.linaro.org,
	linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)

On Fri, 15 Jul 2016 14:08:37 +0200
Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote:

> + Steven
> 
> * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
> 
> >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:  
> >> 
> >>         arm64-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >> 
> >>         arm64-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >> 
> >>         arm-multi_v7_defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >> 
> >>         arm-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >> 
> >>         arm-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >> 
> >>         arm64-defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]  
> >
> >These all started failing yesterday with v3.14.72-rt76, before it was
> >
> >	v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
> >
> >	Arnd  
> 

Arnd,

Does this fix the issue?

-- Steve

diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h
index 65759d8b0b46..25c09df2c046 100644
--- a/include/asm-generic/preempt.h
+++ b/include/asm-generic/preempt.h
@@ -7,7 +7,7 @@
 
 static __always_inline int preempt_count(void)
 {
-	return READ_ONCE(current_thread_info()->preempt_count);
+	return ACCESS_ONCE(current_thread_info()->preempt_count);
 }
 
 static __always_inline volatile int *preempt_count_ptr(void)