linux-kernel - Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 15:35:50 -0700
From:	Steve Longerbeam <slongerbeam@...il.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	p.zabel@...gutronix.de, dri-devel@...ts.freedesktop.org,
	LKML <linux-kernel@...r.kernel.org>,
	Steve Longerbeam <steve_longerbeam@...tor.com>
Subject: Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit



On 07/10/2016 05:02 PM, Paul Gortmaker wrote:
>
> +#include <linux/export.h>
> +#include <linux/module.h>
> You have a u32 field in a struct called "modules" but aside from that, I do not
> see anything in this code requiring module.h -- did I miss something?
>
> You might want export.h for EXPORT_SYMBOL though.
>
>

Hi Paul, yes module.h wasn't needed. Fixed in next version.

Steve