lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Jul 2016 02:51:34 +0200 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: Lv Zheng <lv.zheng@...el.com> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [RFC PATCH 3/3] ACPI / PM: Fix EC polling issue by implementing prepare_late/finish_early suspend_ops callbacks On Tuesday, June 28, 2016 04:04:46 PM Lv Zheng wrote: > _PTS/_WAK may contain EC transactions, it is better to have them handled > with IRQ enabled. This patch moves the 2 suspend PM ops from noirq stage > to late/early stage. > > Signed-off-by: Lv Zheng <lv.zheng@...el.com> There are systems that won't work with this patch applied, so I don't see a point in applying the other two. > --- > drivers/acpi/sleep.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > index d30fce7f..c5c374c9 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -595,9 +595,10 @@ static int acpi_suspend_state_valid(suspend_state_t pm_state) > static const struct platform_suspend_ops acpi_suspend_ops = { > .valid = acpi_suspend_state_valid, > .begin = acpi_suspend_begin, > - .prepare_noirq = acpi_pm_prepare, > + .prepare_late = __acpi_pm_prepare, > + .prepare_noirq = acpi_pm_pre_suspend, > .enter = acpi_suspend_enter, > - .finish_noirq = acpi_pm_finish, > + .finish_early = acpi_pm_finish, > .end = acpi_pm_end, > }; > > Thanks, Rafael
Powered by blists - more mailing lists