linux-kernel - Re: [PATCH 7/8] drm/amd/powerplay: Change assignment for a buffer variable in phm_dispatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Jul 2016 17:03:23 +0200
From:	walter harms <wharms@....de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
CC:	dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
	Christian König <christian.koenig@....com>,
	Alex Deucher <alexander.deucher@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 7/8] drm/amd/powerplay: Change assignment for a buffer
 variable in phm_dispatch_table()



Am 16.07.2016 17:08, schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 16 Jul 2016 15:36:36 +0200
> 
> The variable "temp_storage" was eventually reassigned with a pointer.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> index 024e22e..735aeb0 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> @@ -60,7 +60,7 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
>  		       void *input, void *output)
>  {
>  	int result = 0;
> -	void *temp_storage = NULL;
> +	void *temp_storage;
>  
>  	if (hwmgr == NULL || rt_table == NULL) {
>  		printk(KERN_ERR "[ powerplay ] Invalid Parameter!\n");
> @@ -73,7 +73,8 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
>  			printk(KERN_ERR "[ powerplay ] Could not allocate table temporary storage\n");
>  			return -ENOMEM;
>  		}
> -	}
> +	} else
> +		temp_storage = NULL;
>  
>  	result = phm_run_table(hwmgr, rt_table, input, output, temp_storage);
>  	kfree(temp_storage);


the handling of rt_table->storage_size == 0 is so better visible.

IMHO in this case the function could return directly either with -EINVAL;
or with 0;  -> more direct more obvious.

if (rt_table->storage_size == 0 )
	return 0;

re,
 wh