linux-kernel - Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2016 21:48:50 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Andrey Pronin <apronin@...omium.org>
Cc:	Peter Huewe <peterhuewe@....de>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	groeck@...omium.org, smbarber@...omium.org, dianders@...omium.org
Subject: Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies

On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote:
> > tpm_tis_core was missing conversion from msec when assigning
> > max timeouts from constants.
> > 
> > Signed-off-by: Andrey Pronin <apronin@...omium.org>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Fixes: 41a5e1cf1fe1

Applied.

/Jarkko

> /Jarkko
> 
> > ---
> >  drivers/char/tpm/tpm_tis_core.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> > index 8110b52..fb8c3de 100644
> > --- a/drivers/char/tpm/tpm_tis_core.c
> > +++ b/drivers/char/tpm/tpm_tis_core.c
> > @@ -666,10 +666,10 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
> >  #endif
> >  
> >  	/* Maximum timeouts */
> > -	chip->timeout_a = TIS_TIMEOUT_A_MAX;
> > -	chip->timeout_b = TIS_TIMEOUT_B_MAX;
> > -	chip->timeout_c = TIS_TIMEOUT_C_MAX;
> > -	chip->timeout_d = TIS_TIMEOUT_D_MAX;
> > +	chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> > +	chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> > +	chip->timeout_c = msecs_to_jiffies(TIS_TIMEOUT_C_MAX);
> > +	chip->timeout_d = msecs_to_jiffies(TIS_TIMEOUT_D_MAX);
> >  	priv->phy_ops = phy_ops;
> >  	dev_set_drvdata(&chip->dev, priv);
> >  
> > -- 
> > 2.6.6
> >